Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call GC on preview unloading #1456

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Call GC on preview unloading #1456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3850d7
Call GC collect on preview unloading
udit3333 Mar 5, 2020
31113e1
Added github issue link
udit3333 Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/modules/previewpane/common/controls/FormHandlerControl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ public virtual void Unload()

this.Controls.Clear();
});

// Call garbage collection at the time of unloading of Preview. This is to mitigate issue with WebBrowser Control not able to dispose properly.
udit3333 marked this conversation as resolved.
Show resolved Hide resolved
// Which is preventing prevhost.exe to exit at the time of closing File explorer.
// Preview Handlers run in a separate process from PowerToys. This will not affect the performance of other modules.
// Mitigate the following Github issue: https://github.com/microsoft/PowerToys/issues/1468
GC.Collect();
}

/// <inheritdoc />
Expand Down