Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcuts Guide, PowerRename, ImageResizer and PowerLauncher settings pages #1589

Merged
merged 18 commits into from
Mar 16, 2020
Merged

Shortcuts Guide, PowerRename, ImageResizer and PowerLauncher settings pages #1589

merged 18 commits into from
Mar 16, 2020

Conversation

niels9001
Copy link
Contributor

Summary of the Pull Request

  • Added Shortcuts Guide and PowerRename settings pages
  • Stylized textstyles and margins
  • Added VisualState logic for sidepanel containing e.g. learn more buttons and contributors list

References

#889 #1484 #1482 #1579

PR Checklist

  • [] Applies to #xxx
  • [] CLA signed. If not, go over here and sign the CLA
  • [] Tests added/passed
  • [] Requires documentation to be updated
  • [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

ivan100sic and others added 18 commits March 5, 2020 21:51
@ivan100sic
Fixed one mishandled case when computing zones (#1470)
2b91903
Fix spelling mistake (#1476)
141b635
@stefansjfw
Move ZoneSetPersistedDataOLD to JsonHelpers (#1405)
1cf8634
Remove unused check for pClassFactory (#1419)
bea8e64 
* Update dllmain.cpp

* Update dllmain.cpp
@wjk
Switch WindowWalker C# project to use PackageReference (#1374)
f6047b8 
* Switch WindowWalker C# project to use PackageReference

* Remove packages.config leftovers

Co-authored-by: William Kent <[email protected]>
@enricogior
Update bundle.js and html index files. (#1502)
52e08a2
@stefansjfw
Editor IO exception handling (#1491)
5581e25 
* Close input stream
Show MessageBox with exception message
Remove unused arguments
Guard all of the Editor input/output code parts and show MessageBox
with appropriate message and issue reporting link

* Extract showing messageBox into method
@PrzemyslawTusinski
Ui rename Zone highlight Opacity (%) - > Zone Opacity (#1504)
7e1f7bd
@vldmr11080
Document fancy zones (#1496)
7653d5f
@crutkas
added in dialog, tweaked layout to be more resiliant to longer text (#…
6379c32 
…1361)
@stefansjfw
Fix deleting custom layouts when closing on SaveApply (#1512)
965b098 
* Fix deleting custom layouts when closing on SaveApply

* Only serialize if SaveApply, not on Cancel or X
@stefansjfw
Fix compiler warning (#1492)
7ac378d
@stefansjfw
Use default options for Utf8JsonWriter (#1497)
4dbe535
@vldmr11080
Move window to last known zone. Support movement in multi-monitor sce…
013a58e 
…nario (#1511)
@ivan100sic
FancyZones editor magnetic snapping effect (#1503)
197bc54 
* FancyZones editor magnetic snapping effect

Implemented a solution to Issue #585: FancyZones: Alignment/Snapping/Ruler

* Fixed VS complaining about names and access modifiers

* Removed reference to unused implementation of snapping in FZE

* Converted integer constants to enums in FZE/Canvas

* Convert a portion of code to a switch statement

* Improved code maintainability

* Fixed a screen resolution bug in FZE/Canvas

Fixed a bug where the editor doesn't respect the new screen resolution.

* Further maintainability improvements

* Fixed a compiler warning

* Changed some variables to camelCase
@enricogior
Now working on 0.15.3 (#1525)
852689b
@ivan100sic
Fixed a Grid editor issue (#1308)
4632224 
* Fixed a Grid editor issue

* Explained the fix in ExtendRangeToHaveEvenCellEdges

* Simplified code in ExtendRangeToHaveEvenCellEdges

* Removed redundant comment, more camelCase
@stefansjfw
Improve readability of EditorWindow (#1515)
83901e5
@crutkas
Copy link
Member

crutkas commented Mar 15, 2020 •
edited
Loading

@Laviusntk any reason to not merge in?

ghost
ghost approved these changes Mar 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I will merge it in.

@crutkas crutkas merged commit 07b1977 into microsoft:dev/settingsV2 Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@niels9001 @crutkas @ivan100sic @stefansjfw @wjk @enricogior @PrzemyslawTusinski @vldmr11080