Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix WinRT-related warnings #1710

Merged
merged 1 commit into from
Mar 26, 2020
Merged

chore: fix WinRT-related warnings #1710

merged 1 commit into from
Mar 26, 2020

Conversation

yuyoyuppe
Copy link
Contributor

Summary of the Pull Request

  • fix idl warning in notifications (interface is declared implicitly if you use its member in an arg)
  • restore W4 and disable W5205 locally with respect to the 3rd party source header

PR Checklist

@yuyoyuppe yuyoyuppe merged commit 0c0ddda into microsoft:master Mar 26, 2020
@yuyoyuppe yuyoyuppe deleted the issue_1495 branch March 26, 2020 13:32
@yuyoyuppe yuyoyuppe mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricogior enricogior enricogior approved these changes

@crutkas crutkas Awaiting requested review from crutkas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyoyuppe @enricogior