Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to settings shellpage and added new XAML layouts for PowerRename, Shortcut Guide, PowerLauncher #1735

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Improvements to settings shellpage and added new XAML layouts for PowerRename, Shortcut Guide, PowerLauncher #1735

merged 1 commit into from
Mar 27, 2020

Conversation

niels9001
Copy link
Contributor

Summary of the Pull Request

  • Added styles for common margins + textblocks
  • Added ShortcutGuide page
  • Added PowerRename page
  • Added PowerLauncher page
  • Added a sidepanel that could include links about the feature and contributors (in Shellpage)
  • Minor styling updates to ShellPage

References

#889 #1484 #1482 #1579

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Not sure if the sidepanel should live in the ShellPage or on the separate pages. Makes it easier for the VisualState/resizing stuff.
  • Do we have a control that we can re-use across settings / editor that take in hot-keys? Would be nice to have something that is in terms of visual style and behavior the same across all apps.
    @laviusmotileng-ms @crutkas Thoughts?

Validation Steps Performed

@enricogior
Copy link
Contributor

Hi @niels9001
just to make sure: this should not be merged in master since we are in the process of releasing 0.16.
Thanks.

@niels9001 niels9001 changed the base branch from master to dev/settingsV2 March 27, 2020 15:00
@niels9001
Copy link
Contributor Author

Hi @niels9001
just to make sure: this should not be merged in master since we are in the process of releasing 0.16.
Thanks.

Fixed!

@enricogior
Copy link
Contributor

Thanks!

@crutkas crutkas merged commit bd0707b into microsoft:dev/settingsV2 Mar 27, 2020
@niels9001 niels9001 deleted the user/niels9001/settings-shellpageimprovements branch March 29, 2020 13:26
ghost pushed a commit that referenced this pull request Apr 7, 2020
ghost pushed a commit that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants