Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Restore original corners #17425

Conversation

SeraphimaZykova
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova commented Apr 1, 2022

Summary of the Pull Request

What is this about:

Restore original corners on the window unsnapping from the zone.

What is included in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@Aaron-Junker
Copy link
Collaborator

Will this be a hotfix?

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but if I snap a window with the new option enable, disable the option and then unsnap the window, it keeps the square borders. If a window has the metadata to return to its original preference when unsnapped, it should still be returned to that preference despite the setting.

@jaimecbernardo
Copy link
Collaborator

Will this be a hotfix?

@Aaron-Junker ,
Possible, since we're getting lots of issues opened for this specific case. Is there something else you think should also go if we do the hotfix?

@Aaron-Junker
Copy link
Collaborator

Will this be a hotfix?

@Aaron-Junker ,
Possible, since we're getting lots of issues opened for this specific case. Is there something else you think should also go if we do the hotfix?

If #17436 is what I think (can't check this currently) it should be a simple fix, but it doesn't have to be in a hotfix. Actually this issue here was the only one that I also saw mentioned many times on reddit.

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Apr 1, 2022
@jaimecbernardo
Copy link
Collaborator

Will this be a hotfix?

@Aaron-Junker ,
Possible, since we're getting lots of issues opened for this specific case. Is there something else you think should also go if we do the hotfix?

If #17436 is what I think (can't check this currently) it should be a simple fix, but it doesn't have to be in a hotfix. Actually this issue here was the only one that I also saw mentioned many times on reddit.

I suspect that isn't a PowerToys issue, I'll get more info from OP

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected, now! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants