Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated KeyboardManager page with the right styles/margins. #2031

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Updated KeyboardManager page with the right styles/margins. #2031

merged 1 commit into from
Apr 10, 2020

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Apr 9, 2020 •
edited
Loading

  • Set the right styles and margins for all UI elements inline with the other pages.
  • Updated the visuals of the ListViews (emphasizing the new key stroke and changes to the width to represent the key shape).

Keyboard manager xaml cleanup

References

PR Checklist

@crutkas
Copy link
Member

crutkas commented Apr 10, 2020

We flipped branches. This needs to be on build-feature branch.

@crutkas
Copy link
Member

crutkas commented Apr 10, 2020

Keyboard manager and settings v2 are there now.

@niels9001 niels9001 changed the base branch from dev/settingsV2 to dev/build-features April 10, 2020 07:36
@crutkas crutkas merged commit 3a46f45 into microsoft:dev/build-features Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutkas crutkas crutkas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niels9001 @crutkas