-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate keyboard manager with settings v2[Part-2] #2107
Integrate keyboard manager with settings v2[Part-2] #2107
Conversation
|
@yuyoyuppe This is an known issue currently with new settings projects I'm adding an Github issue for it now. What is happening the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that helped. We'd like to minimize the pt module interface in the future, so please consider using another mechanism to communicate between settings and the module (preferably via some .json file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sure I'm currently leveraging the logic implemented in SettingsV2 which uses Ipc to communicate with the modules. As we update the logic for new Settings and modules to communicate with either file based trigger implementation or some other mechanism we can leverage same logic here as well. |
Summary of the Pull Request
Adding Custom Actions to trigger
Keyboard Manager
module to launchRemap Keyboard
andEdit Shortcuts
windows.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Validated locally by launching both
Remap Keyboard
andEdit Shortcuts
window from the settings UI.