Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tests and Refactored code #2129

Merged
21 commits merged into from
Apr 17, 2020
Merged

Added Tests and Refactored code #2129

21 commits merged into from
Apr 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2020

Summary of the Pull Request

  • Added tests for the implemented settings.
  • Refactored code - move business logic to the ViewModels.

References

PR Checklist

  • Applies to Fluent UX: Settings #889
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • [] Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where a discussion took place: Fluent UX: Settings #889

Validation Steps Performed

  • Ran tests

@ghost ghost requested review from crutkas, traies, yuyoyuppe and a team April 14, 2020 20:36
@crutkas crutkas mentioned this pull request Apr 14, 2020
Closed
udit3333
udit3333 reviewed Apr 14, 2020
View reviewed changes
PowerToys.sln Outdated Show resolved Hide resolved
@crutkas crutkas added the Product-Settings The standalone PowerToys Settings application label Apr 15, 2020
traies
traies reviewed Apr 15, 2020
View reviewed changes
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/GeneralViewModel.cs Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/GeneralViewModel.cs Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/GeneralViewModel.cs Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/GeneralViewModel.cs Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/PowerPreviewViewModel.cs Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/PowerRenameViewModel.cs Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/PowerRenameViewModel.cs Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/ViewModels/PowerRenameViewModel.cs Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/Views/GeneralPage.xaml Outdated Show resolved Hide resolved
src/core/Microsoft.PowerToys.Settings.UI/Views/GeneralPage.xaml Outdated Show resolved Hide resolved
@ghost ghost force-pushed the user/lamotile/refactoring_plus_tests branch from b37216e to 1aed3a6 Compare April 17, 2020 02:24
@ghost ghost force-pushed the user/lamotile/refactoring_plus_tests branch from 9ac0d53 to cc52663 Compare April 17, 2020 15:31
@ghost ghost requested review from a team, traies and udit3333 April 17, 2020 17:49
udit3333
udit3333 reviewed Apr 17, 2020
View reviewed changes
src/settings/main.cpp Outdated Show resolved Hide resolved
udit3333
udit3333 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@udit3333 udit3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 3fc738b into dev/build-features Apr 17, 2020
@ghost ghost deleted the user/lamotile/refactoring_plus_tests branch April 17, 2020 22:25
traies pushed a commit that referenced this pull request Apr 20, 2020
@traies
Added Tests and Refactored code (#2129)
27c93b8 
* Added Tests and Refactored code

* removed un-used file

* delete test files when test completes

* removed extra build configs

* added clean-up method

* removed unused variable

* re-added removed attributtion

* added error handling and move strings to string resource

* added error handling to file explorer view model

* moved varible assignment to if statement block

* removed savin of settings file from the UI

* re-added open source notice

* added missing controls for powerrename and fancy zones

* removed dead coded

* remove un-used configuration

* added error handling for file saving and updated powerreanme constructor

* removed added configurations

* added settings state
@royvou royvou mentioned this pull request Aug 18, 2020
Closed
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutkas crutkas Awaiting requested review from crutkas

@yuyoyuppe yuyoyuppe Awaiting requested review from yuyoyuppe

@traies traies Awaiting requested review from traies

Assignees
No one assigned
Labels
Product-Settings The standalone PowerToys Settings application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traies @udit3333 @crutkas