Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception throw #28104

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Fix exception throw #28104

merged 3 commits into from
Aug 24, 2023

Conversation

davidegiacometti
Copy link
Collaborator

@davidegiacometti davidegiacometti commented Aug 23, 2023

Summary of the Pull Request

  • Fix how exceptions are throw in the PowertoyModuleIface to avoid runner crash.
  • Also fixed a settings crash caused by FindMyMouse activation mode not falling in a valid range. FindMyMouseActivationMethod is binded as SelectedIndex in the ComboBox.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Verified that PowerToys.exe isn't crashing with invalid settings for FindMyMouse, MouseHighlighter, MousePointerCrosshairs and ShortcutGuide

@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/issue-28103 branch from e96dfe3 to 077e40f Compare August 23, 2023 19:05
Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@UrbanPotato
Copy link

does this address the same type of crash we are experiencing with mouse without boarders ? #27126

@stefansjfw
Copy link
Collaborator

does this address the same type of crash we are experiencing with mouse without boarders ? #27126

Doesn't look like. @yuyoyuppe Can you take a look at #27126 ?

@stefansjfw
Copy link
Collaborator

Feel free to merge whenever :)

@davidegiacometti davidegiacometti merged commit 738072f into main Aug 24, 2023
10 checks passed
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/issue-28103 branch August 24, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants