-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Advanced Paste] Online AI models GPO #33045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial changes looking at the code. Haven't tested yet.
@stefansjfw As the primary usecase is to block usage of ai features we should nane it so. This is a well known doing in Windows and other tools. So lets call it "Disable AI ...." with default to "not configured" and "GPO enabled=No AI" and "GPO disabled/not configured=User can enable". |
|
||
public bool ShowOnlineAIModelsGpoConfiguredInfoBar | ||
{ | ||
get => _onlineAIModelsIsGPOConfigured && _enabledGpoRuleConfiguration != GpoRuleConfigured.Disabled; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get => _onlineAIModelsIsGPOConfigured && _enabledGpoRuleConfiguration != GpoRuleConfigured.Disabled; | |
get => _onlineAIModelsIsGPOConfiguredToDisableAI && _enabledGpoRuleConfiguration != GpoRuleConfigured.Disabled; |
For better clarification we should make the var name more precise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the suggestion. I was already on it from figuring out another bug and renamed it IsOnlineAIModelsDisallowedByGPO
Don't forget to update the docs on https://learn.microsoft.com/en-us/windows/powertoys/grouppolicy .
|
@htcfreek , We're basing this off on another setting we have there, which is "Allow experimentation". And also on the OS like the one that exists to allow clipboard history: |
Did some fixes and updated with some images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
src/modules/AdvancedPaste/AdvancedPaste/Strings/en-us/Resources.resw
Outdated
Show resolved
Hide resolved
…s.resw Co-authored-by: Heiko <[email protected]>
@jaimecbernardo , @stefansjfw |
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed