Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Paste] Online AI models GPO #33045

Merged
merged 8 commits into from
May 26, 2024
Merged

Conversation

stefansjfw
Copy link
Collaborator

@stefansjfw stefansjfw commented May 24, 2024

Summary of the Pull Request

image

image

image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial changes looking at the code. Haven't tested yet.

src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved
src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved
src/gpo/assets/en-US/PowerToys.adml Outdated Show resolved Hide resolved
src/gpo/assets/PowerToys.admx Outdated Show resolved Hide resolved
@stefansjfw stefansjfw changed the title [Advanced Paste] AI gpo [Advanced Paste] Online AI models gpo May 24, 2024
@stefansjfw stefansjfw changed the title [Advanced Paste] Online AI models gpo [Advanced Paste] Online AI models GPO May 24, 2024
@htcfreek
Copy link
Collaborator

@stefansjfw
I am sure this is #32947. You are faster than I 😅.

As the primary usecase is to block usage of ai features we should nane it so. This is a well known doing in Windows and other tools. So lets call it "Disable AI ...." with default to "not configured" and "GPO enabled=No AI" and "GPO disabled/not configured=User can enable".

@htcfreek htcfreek added the Hot Fix Items we will product an out-of-band release for label May 24, 2024

public bool ShowOnlineAIModelsGpoConfiguredInfoBar
{
get => _onlineAIModelsIsGPOConfigured && _enabledGpoRuleConfiguration != GpoRuleConfigured.Disabled;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
get => _onlineAIModelsIsGPOConfigured && _enabledGpoRuleConfiguration != GpoRuleConfigured.Disabled;
get => _onlineAIModelsIsGPOConfiguredToDisableAI && _enabledGpoRuleConfiguration != GpoRuleConfigured.Disabled;

For better clarification we should make the var name more precise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the suggestion. I was already on it from figuring out another bug and renamed it IsOnlineAIModelsDisallowedByGPO

@htcfreek
Copy link
Collaborator

Don't forget to update the docs on https://learn.microsoft.com/en-us/windows/powertoys/grouppolicy .

  • The Utility table for the main policy.
  • Add a new block like we have for PT Run for the AI GPO.

@jaimecbernardo
Copy link
Collaborator

@stefansjfw I am sure this is #32947. You are faster than I 😅.

As the primary usecase is to block usage of ai features we should nane it so. This is a well known doing in Windows and other tools. So lets call it "Disable AI ...." with default to "not configured" and "GPO enabled=No AI" and "GPO disabled/not configured=User can enable".

@htcfreek , We're basing this off on another setting we have there, which is "Allow experimentation". And also on the OS like the one that exists to allow clipboard history:
image

src/common/utils/gpo.h Outdated Show resolved Hide resolved
@jaimecbernardo
Copy link
Collaborator

Did some fixes and updated with some images

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jaimecbernardo jaimecbernardo merged commit d0d2f3c into main May 26, 2024
15 checks passed
@htcfreek
Copy link
Collaborator

@jaimecbernardo , @stefansjfw
Don't forget to update the GPO docs. Abd the utility enabled policy is also misding on the docs page.

@crutkas crutkas deleted the stefan/adv_paste_ai_gpo branch June 15, 2024 03:29
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.82 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants