-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWB > Settings + GP] Add new MWB GPs and improve settings ui for TransferFile setting #33571
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/settings-ui/Settings.UI/ViewModels/MouseWithoutBordersViewModel.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
src/settings-ui/Settings.UI/ViewModels/MouseWithoutBordersViewModel.cs
Outdated
Show resolved
Hide resolved
src/settings-ui/Settings.UI/ViewModels/MouseWithoutBordersViewModel.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jaimecbernardo |
@crutkas |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jaimecbernardo |
@jaimecbernardo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Haven't tested everything separately but looks like old behavior won't be affected and UI changes look good as well.
Thank you for the contribution!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I tested the behavior of every single policy on my local build. |
Summary of the Pull Request
Improve settings page for TransferFile setting
The TransferFile setting depends on ShareClipboard setting. This is now visually shwon.
Before the change:
After the change
New policies are added for MWB
Disables the feature if set to disabled.
Disables the feature if set to disabled.
User Interface screenshots
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed