Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWB > Settings + GP] Add new MWB GPs and improve settings ui for TransferFile setting #33571

Merged
merged 31 commits into from
Jul 22, 2024

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Jun 30, 2024

Summary of the Pull Request

Improve settings page for TransferFile setting

The TransferFile setting depends on ShareClipboard setting. This is now visually shwon.

Before the change:
image
After the change
image

New policies are added for MWB

Name Supported states Id Behavior
Clipboard sharing enabled disabled MwbClipboardSharingEnabled Disables the feature if set to disabled.
File transfer enabled disabled MwbFileTransferEnabled Disables the feature if set to disabled.
Original user interface enabled disabled MwbUseOriginalUserInterface Disables the feature if set to disabled.
Disallow blocking screensaver on other machines enabled MwbDisallowBlockingScreensaver Disables the feature if set to enabled.
Connect only in same subnet enabled & disabled MwbSameSubnetOnly Enables the feature if set to enabled.
Disables the feature if set to disabled.
Validate remote machine IP Address enabled & disabled MwbValidateRemoteIp Enables the feature if set to enabled.
Disables the feature if set to disabled.
Disable user defined IP Address mapping rules enabled MwbDisableUserDefinedIpMappingRules If enabled the user can't define IP Address mapping rules.
Predefined IP Address mappings enabled with multi-line text value MwbPolicyDefinedIpMappingRules Allows admins to force define IP Address mapping rules.

User Interface screenshots

image
image
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@htcfreek htcfreek self-assigned this Jun 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek added Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) and removed Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) labels Jul 2, 2024
@htcfreek
Copy link
Collaborator Author

htcfreek commented Jul 2, 2024

@jaimecbernardo
I can not build (debug mode) the setting ui anymore after implementing the GPOs in the ViewModel. And the pipeline is failing with the same errors tellinge me that the GPOWrapper does not contain the policy methods. That makes no sense. Any idea? Is there a mistake that I overlooked?
image
image

@htcfreek htcfreek marked this pull request as ready for review July 3, 2024 15:47
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Jul 3, 2024
@htcfreek htcfreek added Product-Mouse Without Borders Refers to the Mouse Without Borders module Area-Enterprise Issues relevant to large enterprises, SCCM, run as admin restrictions, ... labels Jul 6, 2024
@htcfreek
Copy link
Collaborator Author

@crutkas
Can you please restart the pipeline.

@crutkas
Copy link
Member

crutkas commented Jul 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@htcfreek
Copy link
Collaborator Author

@jaimecbernardo
I merged main in and all conflicts are fixed. This is ready for review.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Jul 22, 2024

@jaimecbernardo
If you like to have this in for 0.83.0 please review the PR until Wednesday evening. Otherwise I will probably not be able to implement the feedback in time.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Haven't tested everything separately but looks like old behavior won't be affected and UI changes look good as well.
Thank you for the contribution!

@jaimecbernardo
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@htcfreek
Copy link
Collaborator Author

Code LGTM! Haven't tested everything separately but looks like old behavior won't be affected and UI changes look good as well.

I tested the behavior of every single policy on my local build.

@htcfreek htcfreek added Good to Merge and removed Needs-Review This Pull Request awaits the review of a maintainer. labels Jul 22, 2024
@jaimecbernardo jaimecbernardo merged commit 16a1fb7 into microsoft:main Jul 22, 2024
13 checks passed
@htcfreek htcfreek deleted the PT_MwbGPO branch July 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Enterprise Issues relevant to large enterprises, SCCM, run as admin restrictions, ... Good to Merge Product-Mouse Without Borders Refers to the Mouse Without Borders module
Projects
Development

Successfully merging this pull request may close these issues.

4 participants