Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QuickAccent]Add degree sign, integral, and vertical ellipsis #34747

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rddunphy
Copy link
Contributor

@rddunphy rddunphy commented Sep 9, 2024

Summary of the Pull Request

Add degree sign, integral, and vertical ellipsis to QuickAccent

PR Checklist

  • Closes: Add degree, pi, and micro symbol to Quick Accent #23237
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: None
  • New binaries: None
  • Documentation updated: None

Detailed Description of the Pull Request / Additional comments

The following symbols are added, as discussed in #23237 :

  • ° (degree sign, U+00B0): added to 0
  • ∫ (integral, U+222B): added to s
  • ⁝ (vertical ellipsis, U+205D): added to .

Screenshot 2024-09-09 222719

The following symbols mentioned in the issue are not added, as they were already present:

  • π (pi, U+03C0): already under p
  • μ (mu/micro, U+03BC): already under m
  • … (horizontal ellipsis, U+2026): already under .
  • ≤ (less than or equal, U+2264): already under = and ,
  • ≥ (greater than or equal, U+2265): already under = and ,

Validation Steps Performed

Manually tested on Win11.

@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 23, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit b927b34 into microsoft:main Sep 24, 2024
9 checks passed
@SanJJ1
Copy link

SanJJ1 commented Oct 27, 2024

Wow thanks for adding the degree sign! just received it in the new update right when I was looking for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants