Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support language change #34971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Support language change #34971

wants to merge 2 commits into from

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

src/common/utils/resources.h Fixed Show fixed Hide fixed
src/common/utils/resources.h Fixed Show fixed Hide fixed
src/common/utils/resources.h Fixed Show fixed Hide fixed
src/common/utils/resources.h Fixed Show fixed Hide fixed
src/common/utils/resources.h Fixed Show fixed Hide fixed
@microsoft microsoft deleted a comment from github-actions bot Sep 19, 2024
@crutkas
Copy link
Member

crutkas commented Sep 19, 2024

🔥🔥🔥🔥🔥🔥

@htcfreek
Copy link
Collaborator

  1. Why do we need a new settings file (json)? Can't we reuse the one containing the utility enabled states?
  2. Do we need an info bar in settings that this not affects any culture settings like date format, time format or currency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants