Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New+ > Settings page] Init fix and fix for enabled state of controls #34999

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[New+ > Settings page] Init fix and fix for enabled state of controls #34999

merged 2 commits into from
Sep 23, 2024

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Sep 22, 2024 •
edited
Loading

⚠ This PR will conflict with #35000 if merged later.

Summary of the Pull Request

This PR fixes two things:

  • Page crashes if no settings file exists.
  • Some controls are disable if module is enabled by policy.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Wrong behavior

image

Correct behavior after changes

image

Validation Steps Performed

@htcfreek htcfreek self-assigned this Sep 22, 2024
@htcfreek htcfreek added Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Priority-1 Bug that is high priority Priority-0 Bugs that we consider release-blocking/recall-class (P0) and removed Priority-1 Bug that is high priority labels Sep 22, 2024
@htcfreek htcfreek changed the title [New+ > Settings pafge] Init fix and fix for enabled state of controls [New+ > Settings page] Init fix and fix for enabled state of controls Sep 22, 2024
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 22, 2024
This was referenced Sep 22, 2024
Open
Merged
@htcfreek
Copy link
Collaborator Author

@crutkas
This should be in for 0.85.0 release. It's an important fix. Is there someone who can review the PR?

jaimecbernardo
jaimecbernardo approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix!

@jaimecbernardo jaimecbernardo merged commit da212b9 into microsoft:main Sep 23, 2024
9 checks passed
@htcfreek htcfreek deleted the PT_NPlus_SettingsFix branch September 23, 2024 12:34
@cgaarden
Copy link
Contributor

Thank you finding and fixing the issue @htcfreek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@stefansjfw stefansjfw Awaiting requested review from stefansjfw

Assignees

@htcfreek htcfreek

Labels
Issue-Bug Something isn't working Needs-Review This Pull Request awaits the review of a maintainer. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application
Projects
5. Needs Attention
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@htcfreek @cgaarden @jaimecbernardo