Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: restore handling of labels on multi line plots in matplot #521

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

jenshnielsen
Copy link
Collaborator

@QCoDeS/core

Following the merge of #495 trying to do multiple lineplots with matplotlib as in

plot = qc.MatPlot()
plot.add(data.this)
plot.add(data.that)

results in labels such as "None (None)" on both axes. This is because axsetter is called with the string "None (None)" the same issue does not exist for pyqtgraph as it directly supports units and
setLabel is called as setLabel(None, None) which is simply interpreted as a noop

This pr restores matching behaviour to matplot

@giulioungaretti giulioungaretti merged commit 50c46c7 into microsoft:master Mar 13, 2017
giulioungaretti pushed a commit that referenced this pull request Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]>

    Fix: restore handling of labels on multi line plots in matplot (#521)
giulioungaretti pushed a commit that referenced this pull request Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]>

    Fix: restore handling of labels on multi line plots in matplot (#521)
giulioungaretti pushed a commit that referenced this pull request Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]>

    Fix: restore handling of labels on multi line plots in matplot (#521)
giulioungaretti pushed a commit that referenced this pull request Mar 13, 2017
Author: Jens Hedegaard Nielsen <[email protected]>

    Fix: restore handling of labels on multi line plots in matplot (#521)
@jenshnielsen jenshnielsen deleted the multilineplotlabels branch March 13, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants