Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<compare>: 0 <=> partial_ordering::unordered returns invalid value #1050

Closed
statementreply opened this issue Jul 16, 2020 · 0 comments · Fixed by #1049
Closed

<compare>: 0 <=> partial_ordering::unordered returns invalid value #1050

statementreply opened this issue Jul 16, 2020 · 0 comments · Fixed by #1049
Labels
bug Something isn't working fixed Something works now, yay!

Comments

@statementreply
Copy link
Contributor

Command-line test case

C:\Users\He\source\test>type partial_unordered.cpp
#include <compare>

static_assert(0 <=> std::partial_ordering::unordered == std::partial_ordering::unordered);

C:\Users\He\source\test>cl /EHsc /std:c++latest /W4 /WX /c partial_unordered.cpp
用于 x64 的 Microsoft (R) C/C++ 优化编译器 19.27.29016 版
版权所有(C) Microsoft Corporation。保留所有权利。

/std:c++latest 作为最新的 C++
working 草稿中的语言功能预览提供。我们希望你提供有关 bug 和改进建议的反馈。
但是,请注意,这些功能按原样提供,没有支持,并且会随着工作草稿的变化
而更改或移除。有关详细信息,请参阅
https://go.microsoft.com/fwlink/?linkid=2045807。

partial_unordered.cpp
partial_unordered.cpp(3): error C2607: 静态断言失败

The error message means "static assertion failed".

STL version

https://github.com/microsoft/STL/commit/8fcc25fe97bee8fa64232aed5848df0d7c0b6d42
@CaseyCarter CaseyCarter added bug Something isn't working work in progress labels Jul 16, 2020
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Jul 16, 2020
StephanTLavavej added a commit that referenced this issue Jul 20, 2020
* Break <compare> ABI again, and fix #1050.

* Remove obsolete conditional compilation from <compare>.

Co-authored-by: statementreply <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Jul 20, 2020
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Jul 28, 2020
* Break <compare> ABI again, and fix microsoft#1050.

* Remove obsolete conditional compilation from <compare>.

Co-authored-by: statementreply <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Something works now, yay!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants