Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for deque::erase(iter, iter) avoiding self-move-assigns #1176

Closed
StephanTLavavej opened this issue Aug 9, 2020 · 0 comments · Fixed by #1203
Closed

Add test coverage for deque::erase(iter, iter) avoiding self-move-assigns #1176

StephanTLavavej opened this issue Aug 9, 2020 · 0 comments · Fixed by #1203
Labels
fixed Something works now, yay! test Related to test code

Comments

@StephanTLavavej
Copy link
Member

#1118 was fixed by #1148, so deque::erase(iter, iter) avoids performing self-move-assigns when called with empty ranges. We should have test coverage for this scenario. Our test for vector can be extended:

// Also test DevCom-776568 "vector::erase(a, a) self-move-assigns the whole vector"
struct CheckSelfMoveAssign {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Something works now, yay! test Related to test code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants