Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<vector>: _Apply_annotation() should be able to _Unfancy() #2470

Closed
StephanTLavavej opened this issue Jan 13, 2022 · 0 comments · Fixed by #2508
Closed

<vector>: _Apply_annotation() should be able to _Unfancy() #2470

StephanTLavavej opened this issue Jan 13, 2022 · 0 comments · Fixed by #2508
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@StephanTLavavej
Copy link
Member

After we merge #2464, @CaseyCarter observed in #2464 (comment) that it should be possible to change _Apply_annotation()'s uses of _Unfancy_maybe_null() to _Unfancy():

STL/stl/inc/vector

Lines 557 to 560 in 0dc93fc

const auto _First = reinterpret_cast<const char*>(_Unfancy_maybe_null(_First_));
const auto _End = reinterpret_cast<const char*>(_Unfancy_maybe_null(_End_));
const auto _Old_last = reinterpret_cast<const char*>(_Unfancy_maybe_null(_Old_last_));
const auto _New_last = reinterpret_cast<const char*>(_Unfancy_maybe_null(_New_last_));

I'm filing a followup issue as #2464 is a high-priority fix that we don't want to delay for a cleanup, however worthy it may be.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jan 13, 2022
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant