Changed _Unfancy_maybe_null() to _Unfancy() #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam20908
approved these changes
Jan 29, 2022
StephanTLavavej
approved these changes
Jan 29, 2022
|
I looked at all of the codepaths that can call this function, and I don't believe that any of them can pass null pointers now, so this appears to be completely correct. 🎉 |
|
By the way, I've edited your PR description to say "Fixes" instead of "Addresses". This activates GitHub's close/fix/resolve syntax, which will automatically close the issue when this PR is merged. (Otherwise it's just a "mention" without auto-closing behavior.) |
CaseyCarter
approved these changes
Jan 30, 2022
StephanTLavavej
approved these changes
Jan 31, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving this code, and congratulations on your first microsoft/STL pull request! 😸 🎉 🚀 This change will appear in VS 2022 17.2 Preview 2 along with the rest of the ASan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2470 and changes instances of
_Unfancy_maybe_null()to_Unfancy().