Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1223R5 ranges::find_last, ranges::find_last_if, ranges::find_last_if_not #2913

Closed
StephanTLavavej opened this issue Jul 25, 2022 · 2 comments · Fixed by #3268
Closed

P1223R5 ranges::find_last, ranges::find_last_if, ranges::find_last_if_not #2913

StephanTLavavej opened this issue Jul 25, 2022 · 2 comments · Fixed by #3268
Labels
cxx23 C++23 feature fixed Something works now, yay! ranges C++20/23 ranges

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 25, 2022 •
edited
Loading

P1223R5 ranges::find_last, ranges::find_last_if, ranges::find_last_if_not

Feature-test macro applied to the WP:

#define __cpp_lib_ranges_find_last 202207L
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jul 25, 2022
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 25, 2022
@SuperWig
Copy link
Contributor

SuperWig commented Oct 31, 2022 •
edited
Loading

Why is the feature macro __cpp_lib_find_last and not __cpp_lib_ranges_find_last?

Edit: Looks like it's because R0 had std:: overloads which were then dropped but the feature test macro wasn't updated... Or not, it didn't have one until R3 so 🤷‍♂️

I've submitted an LWG issue.

This is now LWG-3807

@StephanTLavavej
Copy link
Member Author

Thanks for filing an issue! Sounds similar to #2922 where that paper was voted in with __cpp_lib_fold which was later changed to __cpp_lib_ranges_fold.

@SuperWig SuperWig mentioned this issue Dec 6, 2022
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx23 C++23 feature fixed Something works now, yay! ranges C++20/23 ranges
Projects
STL C++23 Features
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

P1223R5: find_last, et al. SuperWig/STL
2 participants
@SuperWig @StephanTLavavej