P1223R5: find_last, et al. #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Dec 9, 2022
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
For find_last and find_last_if, this transformation is easy - add additional values with a `.second` component of `1729`, which allows us to verify that we always find the last one. The find_last_if_not test was following the existing find_if_not test, but that's difficult to adapt to "make sure we find the last one". So I've simply taken the find_last_if test and inverted the predicates - not not cat is cat.
StephanTLavavej
approved these changes
Dec 13, 2022
CaseyCarter
requested changes
Dec 13, 2022
strega-nil-ms
suggested changes
Dec 13, 2022
CaseyCarter
approved these changes
Dec 14, 2022
CaseyCarter
approved these changes
Dec 14, 2022
strega-nil-ms
approved these changes
Dec 14, 2022
StephanTLavavej
approved these changes
Dec 15, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing these ranges algorithms! 🐱 🐈 🐈⬛ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2913.
I hope I'm doing the unwrapping, re-unwrapping stuff correctly.