Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<xatomic.h>: Investigate making this a core header #3103

Closed
StephanTLavavej opened this issue Sep 14, 2022 · 2 comments · Fixed by #3116
Closed

<xatomic.h>: Investigate making this a core header #3103

StephanTLavavej opened this issue Sep 14, 2022 · 2 comments · Fixed by #3116
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@StephanTLavavej
Copy link
Member

<xatomic.h> is currently a non-core header:

#include <yvals.h>

In #3048, we found that we might want to centralize some macro machinery here, but before we drag it into the import lib, <xatomic.h> really ought to be a core header (as we've had trouble with non-core headers getting into the import lib).

It should be possible to make this into a core header with a bit of investigation.

@frederick-vs-ja
Copy link
Contributor

I've noticed that there are several internal core headers that are never included by standard core headers. Can we add a test for their core-ness?

@CaseyCarter
Copy link
Member

I've noticed that there are several internal core headers that are never included by standard core headers. Can we add a test for their core-ness?

std/tests/GH_001411_core_headers enforces core-ness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants