Make <xatomic.h>, <xbit_ops.h>, and <xerrc.h> core headers
#3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a comment for <yvals_core.h>.
CaseyCarter
approved these changes
Sep 20, 2022
StephanTLavavej
approved these changes
Sep 22, 2022
|
✅ No modules impact! |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this core improvement! 🚀 📈 🎉 |
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add test coverage for internal core headers in
std/tests/GH_001411_core_headers.Some internal core headers are not separatedly tested because they are included by standard core headers.
Fixes #3103.