Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<execution>: Consider separating type and data member declarations #330

Closed
CaseyCarter opened this issue Nov 26, 2019 · 0 comments · Fixed by #3178
Closed

<execution>: Consider separating type and data member declarations #330

CaseyCarter opened this issue Nov 26, 2019 · 0 comments · Fixed by #3178
Assignees
@CaseyCarter
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@CaseyCarter
Copy link
Member

As discussed here, some class definitions in <execution> (e.g.,

STL/stl/inc/execution

Lines 835 to 837 in 1980e1a

using _Target_diff = _Iter_diff_t<_RanIt>;
_Unwrapped_t<_RanIt> _Start_at;
using _Chunk_type = _Iterator_range<_Unwrapped_t<_RanIt>>;
) unconventionally intermix type and data member definitions. It would be nice if these were updated to our conventional "types - blank line - data members - blank line - member functions" layout for structs.
@CaseyCarter CaseyCarter added enhancement Something can be improved work in progress labels Nov 26, 2019
@CaseyCarter CaseyCarter self-assigned this Nov 26, 2019
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Nov 26, 2019
@CaseyCarter
[NFC] Cleanup struct definitions in <execution>
861897a 
Some of these `struct` definitions intermix type definitions with data members, this change reorganizes them into our conventional "types - data members - member functions" layout for `struct`s.

Resolves microsoft#330.
@CaseyCarter CaseyCarter mentioned this issue Nov 26, 2019
Merged
4 tasks
CaseyCarter added a commit to CaseyCarter/STL that referenced this issue Oct 25, 2022
@CaseyCarter
Keep type and data member definitions together in <execution>
f8a9403 
Fixes microsoft#330
@CaseyCarter CaseyCarter mentioned this issue Oct 25, 2022
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaseyCarter CaseyCarter

Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Miscellaneous Cleanups CaseyCarter/STL
2 participants
@CaseyCarter @StephanTLavavej