Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish P0811R3 midpoint and lerp #1048

Merged
merged 12 commits into from
Jul 30, 2020
Merged

Commits on Jul 16, 2020

  1. Finish P0811R3 midpoint(), lerp()

    * Removes workaround for missing `bit_cast()` and mark `lerp()` constexpr.
    
    * Changes how `lerp()` handles infinity inputs according to
      microsoft#65 (comment) and
      microsoft#65 (comment).
    statementreply committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    fd1590b View commit details
    Browse the repository at this point in the history
  2. Update tests for lerp()

    * Adds constexpr tests.
    
    * Updates test cases for infinity inputs according to the new behavior.
    statementreply committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    d554f60 View commit details
    Browse the repository at this point in the history
  3. Apply clang-format

    clang-format has seemingly changed its mind on some unrelated code :\
    statementreply committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e3a405a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Use template variable

    statementreply committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    e5c0662 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2f612b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Configuration menu
    Copy the full SHA
    033632e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98b19bb View commit details
    Browse the repository at this point in the history
  3. Update tests

    statementreply committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    fbd2c52 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9305264 View commit details
    Browse the repository at this point in the history
  5. Minor fixes

    statementreply committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    c9a2ba5 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Configuration menu
    Copy the full SHA
    57e9826 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Fix a subtle conformance issue.

    It's technically nonconformant to explicitly specialize a non-inline
    variable template (and _INLINE_VAR is inline for C++17 and above). MSVC
    accepts this, but it causes problems for Clang.
    tests/std/tests/Dev09_172666_tr1_tuple_odr detected this in the
    MSVC-internal repo, but not on GitHub due to an oversight that we just
    discovered and are fixing (it has one.cpp and two.cpp files instead of
    test.cpp, so we need to add a custom run script).
    
    We can fix this by just using a struct template with static constexpr
    data members.
    
    A couple of other changes here: Use is_floating_point_v instead
    of ::value, and _Float_abs_bits doesn't need to static_cast at the end
    (the inputs to bitwise-AND are the same type and are unsigned int or
    unsigned long long, so there's no integral promotions involved).
    
    cmath: Add Oxford comma to comment.
    
    numeric: Now that we require is_integral_v, _Arithmetic should be
    renamed to _Integral.
    StephanTLavavej committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    af71038 View commit details
    Browse the repository at this point in the history