Implement ranges::sample and ranges::shuffle #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for the initial review, @statementreply! 😸 Moving to WIP as you've identified the cause of (at least one of) the test failures (mentioning a nonexistent |
Co-authored-by: statementreply <[email protected]>
|
It seems activating the tests actually helps... |
Co-authored-by: statementreply <[email protected]>
miscco
changed the title
miscco
changed the title
|
Given that we move the concept definition into algorithm I have put the ranges::shuffle implementation into this PR as otherwise merging is a hassle and both are similar anyway |
|
Tests are active and passing so this should be ready for review |
CaseyCarter
requested changes
Jul 20, 2020
CaseyCarter
reviewed
Jul 21, 2020
CaseyCarter
approved these changes
Jul 22, 2020
Avoid contextually converting integer to bool.
StephanTLavavej
requested changes
Jul 22, 2020
StephanTLavavej
approved these changes
Jul 23, 2020
StephanTLavavej
approved these changes
Jul 23, 2020
|
Thanks for implementing these algorithms, whose choice I suspect was actually quite deliberate - not random at all. |
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 28, 2020
Co-authored-by: statementreply <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the sampling algorithm to ranges.
I am unsure what exactly the problem is with the tests. I guess somecombinations of the machinery do not play well with the requirements but I have to figure out which.