Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::lexicographical_compare #1081

Merged
merged 3 commits into from
Aug 9, 2020
Merged

Implement ranges::lexicographical_compare #1081

merged 3 commits into from
Aug 9, 2020

Conversation

CaseyCarter
Copy link
Member

Partially addresses #39.

@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 24, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 24, 2020 01:28
@CaseyCarter CaseyCarter mentioned this pull request Jul 24, 2020
Closed
StephanTLavavej
StephanTLavavej requested changes Jul 24, 2020
View reviewed changes
tests/std/test.lst Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_lexi/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_lexi/test.cpp Outdated Show resolved Hide resolved
@cbezault cbezault removed their assignment Aug 5, 2020
@StephanTLavavej StephanTLavavej self-assigned this Aug 8, 2020
@StephanTLavavej StephanTLavavej merged commit eb33f1a into microsoft:master Aug 9, 2020
@StephanTLavavej
Copy link
Member

Thanks for implementing this algorithm! Is this the algorithm in the STL with the greatest number of syllables? 😹

@CaseyCarter
Copy link
Member Author

Thanks for implementing this algorithm! Is this the algorithm in the STL with the greatest number of syllables? 😹

I believe it's tied for first with lexicographical_compare_three_way. (Arbitrarily chosen rules: counting the number of syllables in the fully-qualified name not including std.)

@CaseyCarter CaseyCarter deleted the lexi branch August 10, 2020 01:34
@CaseyCarter
Copy link
Member Author

CaseyCarter commented Aug 10, 2020 •
edited
Loading

Thanks for implementing this algorithm! Is this the algorithm in the STL with the greatest number of syllables? 😹

I believe it's tied for first with lexicographical_compare_three_way. (Arbitrarily chosen rules: counting the number of syllables in the fully-qualified name not including std.)

We really should have a ranges::lexicographical_compare_three_way, if for no other reason than to resolve the ambiguity over the longest algorithm name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@cbezault cbezault cbezault approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyCarter @StephanTLavavej @cbezault