Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests Dev09_172666_tr1_tuple_odr and VSO_0000000_matching_npos_address #1109

Merged
merged 3 commits into from
Aug 1, 2020

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Jul 30, 2020

.... which both need a custom build process.

These tests haven't been running in the Azure Pipelines test machinery.

.... which has a custom build process.
@CaseyCarter CaseyCarter added the test Related to test code label Jul 30, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 30, 2020 00:27
@CaseyCarter

This comment has been minimized.

@CaseyCarter CaseyCarter changed the title Enable tests/std/tests/Dev09_172666_tr1_tuple_odr Enable tests Dev09_172666_tr1_tuple_odr and VSO_0000000_matching_npos_address Jul 30, 2020
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@cbezault cbezault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get back to cleaning up all this test stuff.

@StephanTLavavej StephanTLavavej merged commit a712fe5 into microsoft:master Aug 1, 2020
@StephanTLavavej
Copy link
Member

Thanks for restoring this important test coverage and saving contributors a bunch of time!

@CaseyCarter CaseyCarter deleted the odr branch August 2, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants