Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsigned changed to unsigned int due to convention #1390

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Unsigned changed to unsigned int due to convention #1390

merged 3 commits into from
Oct 29, 2020

Conversation

futuarmo
Copy link
Contributor

@futuarmo futuarmo commented Oct 21, 2020 •
edited
Loading

Using of unsigned changed to unsigned int according to convention (comment)

Fixes #1389

@futuarmo futuarmo requested a review from a team as a code owner October 21, 2020 17:02
@ghost
Copy link

ghost commented Oct 21, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@futuarmo futuarmo closed this Oct 21, 2020
@futuarmo futuarmo reopened this Oct 21, 2020
@CaseyCarter CaseyCarter added the test Related to test code label Oct 21, 2020
CaseyCarter
CaseyCarter requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion with the issue description.

tests/std/tests/P0220R1_optional/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0088R3_variant/test.cpp Show resolved Hide resolved
@CaseyCarter CaseyCarter self-assigned this Oct 21, 2020
@CaseyCarter CaseyCarter removed their assignment Oct 22, 2020
@StephanTLavavej StephanTLavavej self-assigned this Oct 29, 2020
@StephanTLavavej StephanTLavavej merged commit 8685c35 into microsoft:master Oct 29, 2020
@StephanTLavavej
Copy link
Member

Thanks for improving the test suite's consistency, and congratulations on your second microsoft/STL commit! 😺 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: Consistently use unsigned int
3 participants
@futuarmo @StephanTLavavej @CaseyCarter