Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accelerate tests by dividing them into shards #1414

Merged
merged 4 commits into from
Nov 6, 2020
Merged

Accelerate tests by dividing them into shards #1414

merged 4 commits into from
Nov 6, 2020

Conversation

cbezault
Copy link
Contributor

@cbezault cbezault commented Nov 2, 2020

No description provided.

@cbezault cbezault added the test Related to test code label Nov 2, 2020
@cbezault
Copy link
Contributor Author

cbezault commented Nov 2, 2020

I still don't get why pulling in the repos sometimes randomly takes 3 minutes.

@cbezault cbezault marked this pull request as ready for review November 2, 2020 20:37
@cbezault cbezault requested a review from a team as a code owner November 2, 2020 20:37
StephanTLavavej
StephanTLavavej approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There will be a trivial (adjacent lines) merge conflict with the /analyze:autolog- change. Also, we'll obviously need special handling due to the required checks changing.

I like how this scales neatly, instead of crudely dividing the tests into libcxx/std/tr1 batches.

@StephanTLavavej StephanTLavavej changed the title Proof of concept for sharding tests Accelerate tests by dividing them into shards Nov 4, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej
microsoftGH-1414 Accelerate tests by dividing them into shards
5fcc861
@StephanTLavavej StephanTLavavej self-assigned this Nov 5, 2020
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej
microsoftGH-1414 Accelerate tests by dividing them into shards
cf37ac9
@StephanTLavavej
Copy link
Member

Trivial merge conflict in azure-devops/run-build.yml; GH-1394 modified CMAKE_CXX_FLAGS (adding /analyze:autolog-) next to this PR modifying CMAKE_BUILD_TYPE (adding $(shardFlags)).

@StephanTLavavej StephanTLavavej merged commit 32fe05b into microsoft:master Nov 6, 2020
@StephanTLavavej
Copy link
Member

Thanks! For! Massively! Reducing! Test! Latency! By! Dividing! Them! Up! Into! Many! Slices!
🍕 🍕 🍕 🍕 🍕 🍕 🍕 🍕

@cbezault
Copy link
Contributor Author

cbezault commented Dec 5, 2020

It's always a joy coming back to old PRs and seeing thank you message puns I had missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbezault @StephanTLavavej @CaseyCarter