Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chrono>: make system_clock::now() and file_clock aware of Windows leap second handling #1588

Closed
wants to merge 30 commits into from
Closed

<chrono>: make system_clock::now() and file_clock aware of Windows leap second handling #1588

wants to merge 30 commits into from

Commits on May 1, 2021

  1. Implement file_time ↔ UTC conversion with leap second handling 

    Windows 10 1809 and Windows Server 2019 introduced support for leap
seconds (enabled by default, could be disabled system-wide). When leap
seconds are enabled, leap seconds after July 2018 are included in the
tick count of `FILETIME`. This is different from the old behavior that
`FILETIME` doesn't count leap seconds. In the future, the same
`FILETIME` value could represent different time points a few seconds
apart depending on whether leap second support is available and enabled.

This commit implements the core algorithm for conversion between
`file_time` and UTC date/time components. It calls Windows
`FileTimeToSystemTime` or `SystemTimeToFileTime` to determine the
interpretation of `FILETIME` by the underlying system.
    @statementreply
    statementreply committed May 1, 2021
    Configuration menu
    Copy the full SHA
    b925e16 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Code cleanup 

    - Return `enum class` instead of `int` error code from `extern C`
  functions.

- Add more `[[nodiscard]]`.

- Remove `_STL_INTERNAL_CHECK` in import lib code, where the checks are
  never performed.

Also modified the fallback behavior for unknown leap second smearing.
    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    375fe5a View commit details
    Browse the repository at this point in the history

  2. Move _Days_from_civil out for use in C++14 mode

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    319e518 View commit details
    Browse the repository at this point in the history

  3. Implement system_clock::now

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    22ccb75 View commit details
    Browse the repository at this point in the history

  4. Update _To_xtime_10_day_clamped to call _Xtime_get_ticks directly

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    2a9b591 View commit details
    Browse the repository at this point in the history

  5. Add tests for Clock::now

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1fa5f71 View commit details
    Browse the repository at this point in the history

  6. _Uglify import lib code

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    5c6f625 View commit details
    Browse the repository at this point in the history

  7. Shorten link to fit in 120 columns

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c3038de View commit details
    Browse the repository at this point in the history

  8. Move bit operator overloads out of extern C

    @statementreply
    statementreply committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7f2a5bd View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Merge branch 'main' into windows-leap-second

    @statementreply
    statementreply committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    4f3d01c View commit details
    Browse the repository at this point in the history

  2. Implement file_time ↔ sys_time conversion

    @statementreply
    statementreply committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    a698c6d View commit details
    Browse the repository at this point in the history

  3. Code review comments 

    Co-authored-by: Miya Natsuhara <[email protected]>
    @statementreply @mnatsuhara
    statementreply and mnatsuhara committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    49bce5a View commit details
    Browse the repository at this point in the history

  4. nextafter requires #include <cmath>

    @statementreply
    statementreply committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    7373b98 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Merge branch 'main' into windows-leap-second 

    Conflicts:
	stl/inc/chrono
    @statementreply
    statementreply committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    44d4bbb View commit details
    Browse the repository at this point in the history

  2. Remove #include <chrono> from import library source

    @statementreply
    statementreply committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    1a22caf View commit details
    Browse the repository at this point in the history

  3. Centralize FILETIME offset value

    @statementreply
    statementreply committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    e4e88ec View commit details
    Browse the repository at this point in the history

  4. Explain the magic tolerance

    @statementreply
    statementreply committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    4296d97 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Merge branch 'main' into windows-leap-second

    @statementreply
    statementreply committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    1336e1f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2021

  1. Implement file_time ↔ utc_time conversion

    @statementreply
    statementreply committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    c5ee629 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @statementreply
    statementreply committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    96d8501 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2021

  1. Fix tests

    @statementreply
    statementreply committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    0c3c998 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    cb7a139 View commit details
    Browse the repository at this point in the history

  2. Implement file_time formatting

    @statementreply
    statementreply committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    5683bc0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    4767cfe View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2021

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    d573b1e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    29f5789 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed May 4, 2022
    Configuration menu
    Copy the full SHA
    5b33476 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    e609aaa View commit details
    Browse the repository at this point in the history

  2. usual_winsdk_matrix.lst no longer exists

    @statementreply
    statementreply committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    fd4ce85 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Merge remote-tracking branch 'upstream/main' into windows-leap-second

    @statementreply
    statementreply committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    bdae556 View commit details
    Browse the repository at this point in the history