Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable constexpr vector internal tests #1690

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Enable constexpr vector internal tests #1690

merged 1 commit into from
Feb 23, 2021

Conversation

eldakesh-ms
Copy link
Contributor

@eldakesh-ms eldakesh-ms commented Feb 23, 2021 •
edited by CaseyCarter
Loading

Uncomments the MSVC_INTERNAL_TESTING conditionals on tests and also
adds a compiler workaround in vector.

Mirrors changes in internal MSVC-PR-305986.

@eldakesh-ms
Enable constexpr vector internal tests
b7063ee 
Uncomments the `MSVC_INTERNAL_TESTING` conditionals on tests and also
adds a compiler workaround in vector.
@eldakesh-ms eldakesh-ms requested a review from a team as a code owner February 23, 2021 17:54
mnatsuhara
mnatsuhara approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@CaseyCarter
Copy link
Member

FYI: this is blocked waiting for CI to pass and the internal PR to merge. When we see MSVC-PR-305986 merge, we'll merge this as well.

@mnatsuhara mnatsuhara mentioned this pull request Feb 23, 2021
Open
@StephanTLavavej StephanTLavavej added the test Related to test code label Feb 23, 2021
@StephanTLavavej StephanTLavavej merged commit 3c13e3e into microsoft:main Feb 23, 2021
@StephanTLavavej
Copy link
Member

Thanks for activating this test coverage and ensuring that users have a high-quality constexpr vector experience! 🎉 😸

Also, congratulations on your first microsoft/STL commit! 🚀 I notice that your GitHub account is linked to the Microsoft Docs organization but not the Microsoft organization, by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldakesh-ms @CaseyCarter @StephanTLavavej @mnatsuhara