Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the STL with /ZH:SHA_256 #1829

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Build the STL with /ZH:SHA_256 #1829

merged 1 commit into from
Jun 3, 2021

Conversation

StephanTLavavej
Copy link
Member

Fixes #1734. Ports Daniel Griffing's MSVC-PR-316297.

@StephanTLavavej StephanTLavavej added the build Related to the build system label Apr 12, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 12, 2021 22:20
@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label May 20, 2021
@StephanTLavavej
Copy link
Member Author

Waiting for the MSVC-PR to be merged.

@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Jun 2, 2021
@CaseyCarter
Copy link
Member

Merging now that the corresponding internal PR has merged.

@CaseyCarter CaseyCarter merged commit aa5145c into microsoft:main Jun 3, 2021
@CaseyCarter
Copy link
Member

Thanks for handling this extremely complicated port!

@StephanTLavavej StephanTLavavej deleted the sha256 branch June 3, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barcharcraz barcharcraz barcharcraz approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should build the STL with /ZH:SHA_256
3 participants
@StephanTLavavej @CaseyCarter @barcharcraz