Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chrono>: Adjust for leap seconds when formatting file_time #1879

Merged
merged 1 commit into from
Jun 29, 2021
Merged

<chrono>: Adjust for leap seconds when formatting file_time #1879

merged 1 commit into from
Jun 29, 2021

Conversation

statementreply
Copy link
Contributor

@statementreply statementreply commented Apr 24, 2021 •
edited by mnatsuhara
Loading

Fixes #1899

This PR does not address #1822.

Edited to link to newly-created issue #1899, made while cleaning out the chrono project.

@statementreply statementreply requested a review from a team as a code owner April 24, 2021 07:14
@StephanTLavavej StephanTLavavej added bug Something isn't working chrono C++20 chrono labels Apr 25, 2021
mnatsuhara
mnatsuhara approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting to this, seems like a good and reasonable change! We need to hurry up and have a leap second post-2018 so we can test this more robustly :P

@mnatsuhara mnatsuhara removed their assignment Jun 21, 2021
@StephanTLavavej StephanTLavavej self-assigned this Jun 24, 2021
@StephanTLavavej StephanTLavavej merged commit ac661bf into microsoft:main Jun 29, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing this lurking correctness bug! 🪲 ⌚ 😸

@statementreply statementreply deleted the filetime_format_leap_second branch August 28, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working chrono C++20 chrono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<chrono>: file_clock also needs leap second handling
3 participants
@statementreply @StephanTLavavej @mnatsuhara