Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filesystem::u8path should accept char8_t sources #1943

Merged
merged 4 commits into from
Jun 29, 2021
Merged

filesystem::u8path should accept char8_t sources #1943

merged 4 commits into from
Jun 29, 2021

Conversation

CaseyCarter
Copy link
Member

Fixes #1941

@CaseyCarter CaseyCarter added the bug Something isn't working label Jun 1, 2021
@CaseyCarter CaseyCarter requested a review from a team as a code owner June 1, 2021 15:56
@CaseyCarter CaseyCarter changed the title filesystem::u8path should accept char8_t sources filesystem::u8path should accept char8_t sources Jun 1, 2021
cpplearner
cpplearner reviewed Jun 12, 2021
View reviewed changes
stl/inc/filesystem Outdated Show resolved Hide resolved
barcharcraz
barcharcraz approved these changes Jun 21, 2021
View reviewed changes
stl/inc/filesystem Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

@CaseyCarter @barcharcraz FYI, I extracted the basic_string_view so we can use it for both overloads. The first overload takes const Source& so changing the argument from a modifiable rvalue to a const lvalue doesn't affect the test.

@StephanTLavavej StephanTLavavej self-assigned this Jun 24, 2021
@StephanTLavavej StephanTLavavej merged commit 46c040d into microsoft:main Jun 29, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug that was hiding in Annex D - always where we least expect to see changes! 😸 🪲 🚀

@CaseyCarter CaseyCarter deleted the u8path branch June 29, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpplearner cpplearner cpplearner left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@barcharcraz barcharcraz barcharcraz approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<filesystem>: u8path doesn't work with char8_t
4 participants
@CaseyCarter @StephanTLavavej @barcharcraz @cpplearner