Adding native_handle to jthread
#1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Jun 8, 2021
CaseyCarter
approved these changes
Jun 8, 2021
CaseyCarter
changed the title
native_handle to jthread
StephanTLavavej
approved these changes
Jun 10, 2021
|
Note (no change requested): reordering member functions can affect ABI, but that's specific to new declarations of virtual functions. These are non-virtual so there's no ABI impact. |
TIL. Thanks STL! |
|
@StephanTLavavej @CaseyCarter - I accidently closed the PR when I just wanted to leave a comment. Sorry for messing up with the Code Review workflow! |
|
Thanks for fixing this high-priority customer-reported bug! 🪲 😺 🎉 |
hidez8891
added a commit
to hidez8891/cpp-debugio
that referenced
this pull request
Sep 20, 2021
VS2019 では std::jthread::native_handle() が実装されていない。 microsoft/STL#1966 そのため、std::threadで代替する。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
thread::native_handle(), this PR addsjthread::native_handle()which callsnative_handlefor internalthread. I don't see any unit tests forthread::native_handle()which is why I am not adding any unit tests for this code change.Resolves #1963