Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chrono> parse subseconds when the underlying type supports it #1987

Merged
merged 3 commits into from
Jun 29, 2021
Merged

<chrono> parse subseconds when the underlying type supports it #1987

merged 3 commits into from
Jun 29, 2021

Conversation

MattStephanson
Copy link
Contributor

@MattStephanson
parse subseconds when the underlying type supports it
7aa7262 
 - Also fixes incorrect behavior when local_time is parsed with a
   UTC offset.
@MattStephanson MattStephanson requested a review from a team as a code owner June 9, 2021 05:48
@StephanTLavavej StephanTLavavej added bug Something isn't working chrono C++20 chrono labels Jun 9, 2021
StephanTLavavej
StephanTLavavej reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll validate and push very minor test changes.

tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Jun 23, 2021
mnatsuhara
mnatsuhara approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@mnatsuhara mnatsuhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks so much for implementing this fix :)

@StephanTLavavej StephanTLavavej merged commit 6b12c4a into microsoft:main Jun 29, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug in a split second! ⚡ 🪲 😸

@MattStephanson MattStephanson deleted the gh-1952 branch September 8, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working chrono C++20 chrono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<chrono>: parse ignores subseconds when the underlying type supports it
3 participants
@MattStephanson @StephanTLavavej @mnatsuhara