Add missing precondition check in forward_list::splice_after
#2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`forward_list::splice_after(target_iterator, some_list, before_source_iterator)` requires that `++before_source_iterator` - the iterator that denotes the element to be removed from `some_list` and inserted into `*this` after `target_iterator` - be dereferenceable. We conventionally don't check preconditions when the result of violation is to dereference a `nullptr`, since the behavior is nicely predictable, but doing so here avoids confusion about what otherwise seems like a reasonable call as in DevCom-1456054.
CaseyCarter
force-pushed
the
forward_list-check
branch
from
4b22528
to
ed08429
Compare
StephanTLavavej
approved these changes
Jul 14, 2021
CaseyCarter
changed the title
forward_list::splice_after
mnatsuhara
approved these changes
Jul 22, 2021
|
Thanks for adding this diagnostic and helping users to understand what's happening! 😸 🧠 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward_list::splice_after(target_iterator, some_list, before_source_iterator)requires that++before_source_iterator- the iterator that denotes the element to be removed fromsome_listand inserted into*thisaftertarget_iterator- be dereferenceable. We conventionally don't check preconditions when the result of violation is to dereference anullptr, since the behavior is nicely predictable, but doing so here avoids confusion about what otherwise seems like a reasonable call as in DevCom-1456054.