Optimize _Non_propagating_cache #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Aug 12, 2021
StephanTLavavej
approved these changes
Aug 14, 2021
Comment on lines
+773
to
+777
| private: | ||
| union { | ||
| _Ty _Val; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
This affects ABI by omitting bool _Engaged = false; (and _Non_propagating_cache is a data member of _Join_view_base). That's acceptable because <ranges> is ABI-unlocked, but we'll need to be certain to port all <ranges> changes to 16.11.
CaseyCarter
reviewed
Aug 19, 2021
CaseyCarter
approved these changes
Aug 19, 2021
StephanTLavavej
approved these changes
Aug 19, 2021
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
|
Thanks for improving the performance here before the ABI lockdown! 🚀 🔐 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a specialization of
_Non_propagating_cachefor trivially destructible types. Also adds a way to disable it for compatibility with #2042.