Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<algorithm> fixes ranges::_Rotate_one_left #2188

Merged
merged 1 commit into from
Sep 11, 2021
Merged

<algorithm> fixes ranges::_Rotate_one_left #2188

merged 1 commit into from
Sep 11, 2021

Conversation

MattStephanson
Copy link
Contributor

Fixes #2187.

@MattStephanson MattStephanson requested a review from a team as a code owner September 4, 2021 00:55
@StephanTLavavej StephanTLavavej added bug Something isn't working high priority Important! ranges C++20/23 ranges labels Sep 4, 2021
@StephanTLavavej StephanTLavavej self-assigned this Sep 10, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo now. Please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 75e7d21 into microsoft:main Sep 11, 2021
@StephanTLavavej
Copy link
Member

Thanks for finding and fixing the root cause of this silent bad codegen! 🐞 🛠️ 😻

@MattStephanson MattStephanson deleted the gh-2187 branch October 6, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@miscco miscco miscco approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working high priority Important! ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<algorithm>: ranges::stable_sort() neither sorts nor permutes
4 participants
@MattStephanson @StephanTLavavej @CaseyCarter @miscco