Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mutex, ranges, functional, any and format visualizers #2191

Merged
merged 20 commits into from
Jul 11, 2022

Conversation

AnjuDel
Copy link
Member

@AnjuDel AnjuDel commented Sep 7, 2021

Adding visualizers for missing mutex elements and more.

Fixes #929.

From @strega-nil-ms: additionally, refactor std::tuple's visualizer.

@AnjuDel AnjuDel requested a review from a team as a code owner September 7, 2021 17:19
@AnjuDel AnjuDel added the visualizer How the VS debugger displays STL types label Sep 7, 2021
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
@AnjuDel AnjuDel changed the title Adding mutex visualizers Adding mutex and format visualizers Sep 9, 2021
@AnjuDel AnjuDel changed the title Adding mutex and format visualizers Adding mutex, any and format visualizers Sep 24, 2021
@AnjuDel AnjuDel changed the title Adding mutex, any and format visualizers Adding mutex, ranges, any and format visualizers Oct 14, 2021
@AnjuDel AnjuDel changed the title Adding mutex, ranges, any and format visualizers Adding mutex, ranges, functional, any and format visualizers Nov 22, 2021
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
@fsb4000

This comment was marked as resolved.

stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
stl/debugger/STL.natvis Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Jul 6, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 7, 2022

For reference, VS-PR-407223 is still active, porting #2784, #2804, and #2811 (MSVC-PR-407231). Marking this PR as blocked until we either clear the pipeline or decide to add this PR to the triple-mirror.

VS-PR-408482 / MSVC-PR-409524 / #2843 are merged.

@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Jul 7, 2022
@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Jul 9, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jul 9, 2022
@StephanTLavavej
Copy link
Member

Let's try mirroring this and sorting out the VS-PR later.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 332154b into microsoft:main Jul 11, 2022
@StephanTLavavej
Copy link
Member

Thanks @AnjuDel and @strega-nil-ms for visualizing all of these types! 👓 🎉 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visualizer How the VS debugger displays STL types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug visualizers: std::any natvis extensions
9 participants