Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3520 #2200

Merged
merged 7 commits into from
Sep 25, 2021
Merged

Implement LWG-3520 #2200

merged 7 commits into from
Sep 25, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Sep 12, 2021

Fixes #2180

@fsb4000 fsb4000 marked this pull request as ready for review September 12, 2021 06:56
@fsb4000 fsb4000 requested a review from a team as a code owner September 12, 2021 06:56
@fsb4000 fsb4000 changed the title Implemente LWG-3520 Implement LWG-3520 Sep 12, 2021
miscco
miscco reviewed Sep 12, 2021
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

To ensure that we indeed cannot do this, it would be great if you would add a concept ``CanIterSwap` to range_algorithm_support.h like

template <class I>
concept CanIterSwap = requires(I&& i1, I&& i2) {
    ranges::iter_swap(std::forward<I>(i1), std::forward<I>(i2));
};

and verify that it is not fulfilled

fsb4000 and others added 2 commits September 12, 2021 18:28
@fsb4000 @miscco
add test
ef6b748 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@fsb4000
check unconditionally
a456b6c
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Sep 13, 2021
CaseyCarter
CaseyCarter approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Sep 15, 2021
@StephanTLavavej StephanTLavavej self-assigned this Sep 15, 2021
StephanTLavavej
StephanTLavavej reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll push a comment change.

tests/std/tests/P0896R4_views_transform/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Sep 17, 2021
@StephanTLavavej StephanTLavavej self-assigned this Sep 23, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ec46d76 into microsoft:main Sep 25, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing and testing this LWG issue resolution, one step closer to 100% conformance! 💯 😸 ✔️

@fsb4000 fsb4000 deleted the fix2180 branch September 25, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBucior AdamBucior AdamBucior left review comments

@miscco miscco miscco left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3520 iter_move and iter_swap are inconsistent for transform_view::iterator
5 participants
@fsb4000 @StephanTLavavej @CaseyCarter @miscco @AdamBucior