Implement changes missed from P1148R0 #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `basic_string(const T& t, size_type, size_type, Alloc = Alloc())` constructor _should_ allow `t`'s convertible to pointer-to-element * Each family of `find` functions is (1) missing conditional `noexcept` on the "convertible-to-`string_view`" overload, and (2) incorrect that `noexcept` on the "element, offset" overload is strengthened We apparently overlooked these bits when implementing P1148R0 which was largely a clean rewording paper. Fixes VSO-1411144 Fixes AB#1411144
StephanTLavavej
approved these changes
Oct 16, 2021
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed, or if more work is required. |
|
Thanks for finding and fixing these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic_string(const T& t, size_type, size_type, Alloc = Alloc())constructor should allowt's convertible to pointer-to-elementfindfunctions is (1) missing conditionalnoexcepton the "convertible-to-string_view" overload, and (2) incorrect thatnoexcepton the "element, offset" overload is strengthenedWe apparently overlooked these bits when implementing P1148R0 which was largely a clean rewording paper. A new internal test suite noticed one of the missed changes, I audited P1148 to find the others.
Fixes VSO-1411144
Fixes AB#1411144