Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chronat tests to deal with locale-dependent time zones abbreviations #2231

Merged
merged 6 commits into from
Nov 13, 2021
Merged

Fix chronat tests to deal with locale-dependent time zones abbreviations #2231

merged 6 commits into from
Nov 13, 2021

Conversation

statementreply
Copy link
Contributor

Fixes #1904.

@statementreply statementreply requested a review from a team as a code owner October 2, 2021 11:17
@StephanTLavavej StephanTLavavej added chrono C++20 chrono test Related to test code labels Oct 2, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing these test failures - both when the US time zones aren't available, and the Australian time zones are! 😻

I went ahead and pushed a small cleanup to reduce code repetition, and a conflict-free merge with main (which wasn't strictly necessary).

@StephanTLavavej StephanTLavavej self-assigned this Nov 12, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed, or if more work is required.

@mnatsuhara mnatsuhara removed their assignment Nov 12, 2021
@StephanTLavavej StephanTLavavej merged commit f1ce816 into microsoft:main Nov 13, 2021
@StephanTLavavej
Copy link
Member

Thanks for fixing these spurious test failures so the whole world can enjoy chronat testing! 🌏 🌍 🌎

@statementreply statementreply deleted the time-zone-abbr branch July 31, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
chrono C++20 chrono test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix chronat tests to deal with locale-dependent time zones abbreviations
3 participants
@statementreply @StephanTLavavej @mnatsuhara