Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement P1072R10 basic_string::resize_and_overwrite #2258

Merged
merged 4 commits into from
Nov 13, 2021

Conversation

AdamBucior
Copy link
Contributor

Fixes #2244.

@AdamBucior AdamBucior requested a review from a team as a code owner October 5, 2021 16:20
@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Oct 5, 2021
stl/inc/xstring Outdated Show resolved Hide resolved
stl/inc/xstring Outdated Show resolved Hide resolved
stl/inc/xstring Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Oct 20, 2021
stl/inc/xstring Outdated Show resolved Hide resolved
stl/inc/xstring Outdated Show resolved Hide resolved
stl/inc/xstring Outdated Show resolved Hide resolved
stl/inc/xstring Show resolved Hide resolved
stl/inc/xstring Outdated Show resolved Hide resolved
tests/std/tests/P0980R1_constexpr_strings/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0980R1_constexpr_strings/test.cpp Outdated Show resolved Hide resolved
@mnatsuhara mnatsuhara removed their assignment Nov 5, 2021
stl/inc/xstring Show resolved Hide resolved
@mnatsuhara mnatsuhara removed their assignment Nov 8, 2021
@StephanTLavavej StephanTLavavej self-assigned this Nov 12, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 2de0fa5 into microsoft:main Nov 13, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this long-requested feature for people using C APIs with basic_string! 🧵 🚀 😸

@AdamBucior AdamBucior deleted the resize_and_overwrite branch November 13, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1072R10 basic_string::resize_and_overwrite
6 participants