Fix ranges::find_end return for bidi-common case #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and add full test coverage. Fixes microsoft#2268
miscco
approved these changes
Oct 12, 2021
miscco
reviewed
Oct 12, 2021
miscco
reviewed
Oct 12, 2021
| Fwd2 needle{good_needle}; | ||
| const same_as<subrange<iterator_t<Fwd1>>> auto result = | ||
| find_end(begin(haystack), end(haystack), begin(needle), end(needle), pred, get_first); | ||
| STATIC_ASSERT( |
There was a problem hiding this comment.
Nitpick, is there a reason to shout STATIC_ASSERT, at least in ranges code we should be able to be a bit less shouty
There was a problem hiding this comment.
Yes there is: I refuse to manually map from line number to failure condition when I can make MSVC do it for me by capitalizing static_assert.
miscco
reviewed
Oct 12, 2021
StephanTLavavej
approved these changes
Oct 15, 2021
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed, or if more work is required. |
mnatsuhara
approved these changes
Nov 12, 2021
|
Thanks for finding the end of this bug! 🐞 🛑 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and add full test coverage.
Fixes #2268