Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3590: split_view::base() const & is overconstrained #2404

Merged
merged 5 commits into from
Dec 17, 2021
Merged

Implement LWG-3590: split_view::base() const & is overconstrained #2404

merged 5 commits into from
Dec 17, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Dec 11, 2021

Fixes #2400

@fsb4000 fsb4000 requested a review from a team as a code owner December 11, 2021 17:14
miscco
miscco approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks

tests/std/tests/P0896R4_views_split/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_split/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_split/test.cpp Outdated Show resolved Hide resolved
@fsb4000 @miscco
simplify begin and end methods
02eab98 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@fsb4000 fsb4000 changed the title Implement LWG-3590 Implement LWG-3590: split_view::base() const & is overconstrained Dec 12, 2021
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Dec 12, 2021
CaseyCarter
CaseyCarter approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a fix for my comments.

tests/std/tests/P0896R4_views_split/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_split/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1174e73 into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution! 🚀 🎉 😺

@fsb4000 fsb4000 deleted the fix2400 branch December 17, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3590 split_view::base() const & is overconstrained
4 participants
@fsb4000 @StephanTLavavej @CaseyCarter @miscco