Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3146: Excessive unwrapping in std::ref/cref #2409

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Implement LWG-3146: Excessive unwrapping in std::ref/cref #2409

merged 3 commits into from
Dec 17, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Dec 12, 2021

Fixes #2391

@fsb4000 fsb4000 requested a review from a team as a code owner December 12, 2021 05:10
miscco
miscco reviewed Dec 12, 2021
View reviewed changes
tests/tr1/tests/functional9/test.cpp Outdated Show resolved Hide resolved
tests/tr1/tests/functional9/test.cpp Outdated Show resolved Hide resolved
@fsb4000 @miscco
test return type
d944686 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
miscco
miscco reviewed Dec 12, 2021
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for going the extra mile

@fsb4000 fsb4000 changed the title Implement LWG-3146 Implement LWG-3146: Excessive unwrapping in std::ref/cref Dec 12, 2021
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Dec 12, 2021
@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3a570ee into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing a third LWG issue resolution in today's batch! 🎁 😸 🚀

@fsb4000 fsb4000 deleted the fix2391 branch December 17, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3146 Excessive unwrapping in std::ref/cref
4 participants
@fsb4000 @StephanTLavavej @CaseyCarter @miscco