Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update counted_iterator's "same sequence" definition #2424

Merged
merged 2 commits into from
Jan 22, 2022

Conversation

CaseyCarter
Copy link
Member

Per LWG-3543. (This is almost a pure non-functional change, but I added a word to the error message we emit on failure.)

Fixes #2184

Per LWG-3543. (This is _almost_ a pure non-functional change, but I added a word to the error message we emit on failure.)

Fixes microsoft#2184
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Dec 17, 2021
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 17, 2021 05:18
@StephanTLavavej
Copy link
Member

@CaseyCarter I pushed a change to add the "(possibly past-the-end)" that appears in the Standard, as when I see a Standard paragraph citation followed by quotes, I expect the quote to be exact (unless it contains "[...]" or something says that it's paraphrased).

I extracted the period purely for style/consistency, although the original way wasn't wrong (as the period really does exist in the Standardese). The second quote is more clearly a "paraphrasing the Standard" usage so I'm not concerned that it doesn't exactly match the Standardese.

If including the parenthetical part is a distraction, please meow!

@barcharcraz barcharcraz removed their assignment Jan 20, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jan 21, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d896ef8 into microsoft:main Jan 22, 2022
@StephanTLavavej
Copy link
Member

Thanks for taking care of this LWG issue resolution! 🚀 😸 ✅

@CaseyCarter CaseyCarter deleted the same_sequence branch August 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWG-3543 Definition of when counted_iterators refer to the same sequence isn't quite right
3 participants