subrange get<0> requires a copyable iterator
#2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per LWG-3589. Fixes microsoft#2399
StephanTLavavej
requested changes
Dec 18, 2021
CaseyCarter
commented
Dec 18, 2021
| @@ -1483,3 +1484,44 @@ namespace test_subrange { | |||
| STATIC_ASSERT(test_tuple<subrange<int*, std::unreachable_sentinel_t, subrange_kind::sized>>()); | |||
| STATIC_ASSERT(test_tuple<subrange<int*, std::unreachable_sentinel_t, subrange_kind::unsized>>()); | |||
| } // namespace test_subrange | |||
|
|
|||
| namespace test_lwg_3589 { | |||
There was a problem hiding this comment.
"LWG" is capitalized on 26.
There was a problem hiding this comment.
I can live with this, no need to reset testing.
StephanTLavavej
approved these changes
Jan 19, 2022
| @@ -1483,3 +1484,44 @@ namespace test_subrange { | |||
| STATIC_ASSERT(test_tuple<subrange<int*, std::unreachable_sentinel_t, subrange_kind::sized>>()); | |||
| STATIC_ASSERT(test_tuple<subrange<int*, std::unreachable_sentinel_t, subrange_kind::unsized>>()); | |||
| } // namespace test_subrange | |||
|
|
|||
| namespace test_lwg_3589 { | |||
There was a problem hiding this comment.
I can live with this, no need to reset testing.
mnatsuhara
approved these changes
Jan 19, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this LWG issue resolution! ✅ 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per LWG-3589.
Fixes #2399